Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made prospectus downloadable #330

Merged

Conversation

ashmit-coder
Copy link
Collaborator

Description

  • Added the current Prospectus PDF and made it downloadable.

Related issue(s)

Resolves: #329

Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 159ffdf
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6672bed59265c50008584e98
😎 Deploy Preview https://deploy-preview-330--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a download icon in the button to make users know that it's a download button?

@ashmit-coder
Copy link
Collaborator Author

Do you mind adding a download icon in the button to make users know that it's a download button?

Sure I can!
Just what icon should I use could you suggest that

@ashmit-coder
Copy link
Collaborator Author

Do you mind adding a download icon in the button to make users know that it's a download button?

Sure I can! Just what icon should I use could you suggest that

In my opinion one of these should be fine https://react-icons.github.io/react-icons/search/#q=download

@AceTheCreator
Copy link
Member

Do you mind adding a download icon in the button to make users know that it's a download button?

Sure I can! Just what icon should I use could you suggest that

In my opinion one of these should be fine https://react-icons.github.io/react-icons/search/#q=download

Hmmm... do we really have to install an icon library?

@AceTheCreator
Copy link
Member

You can just do it the way it's been done already

@ashmit-coder
Copy link
Collaborator Author

You can just do it the way it's been done already

No I mean just suggest a icon from that page I will implement the way we do it 😅

@ashmit-coder
Copy link
Collaborator Author

Contributor

Hey @AceTheCreator or @thulieblack , could you suggest something over this?

@thulieblack
Copy link
Member

Not sure what @AceTheCreator meant by the download icon.

Maybe specify on the Button text that -Download Sponsorship Prospectus

image

@ashmit-coder
Copy link
Collaborator Author

Not sure what @AceTheCreator meant by the download icon.

Maybe specify on the Button text that -Download Sponsorship Prospectus

image

He meant the same thing, just instead of Download in text we use a download icon

@thulieblack
Copy link
Member

thulieblack commented Jun 19, 2024

Can't you embed the icon on the button?

image

@ashmit-coder
Copy link
Collaborator Author

Can't you embed the icon on the button?

image

Yeah thats exactly what we where thinking, 😅 .

Just the doubt was whay icon will go properly with the theme.

Hence I suggested using https://react-icons.github.io/react-icons/search/#q=download
One of the in the url in Image format ( the usual way in the site)

@thulieblack
Copy link
Member

lets try that and see how it;ll look

@asyncapi-bot
Copy link
Contributor

@thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AceTheCreator AceTheCreator merged commit c5703fc into asyncapi:master Jun 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make Sponsorship Prospectus downloadable
4 participants